Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#68074: Only add padding to inputBox if find options are enabled in findInput #68467

Merged
merged 1 commit into from
Feb 15, 2019
Merged

#68074: Only add padding to inputBox if find options are enabled in findInput #68467

merged 1 commit into from
Feb 15, 2019

Conversation

frobinsonj
Copy link
Contributor

@frobinsonj frobinsonj commented Feb 11, 2019

This PR removes the (unneeded) padding from the findWidget input when there are no find options.

Fixes #68074
@mjbvz My apologies for the bad explanation in the issue. Hopefully this clears up any confusion.

Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help, it works as described.

@rebornix rebornix merged commit 0e30c34 into microsoft:master Feb 15, 2019
@frobinsonj frobinsonj deleted the find-input-padding branch February 15, 2019 19:38
@roblourens
Copy link
Member

I need to adjust the search view for this too, #68977. setInputWidth could be deleted, but does anybody know why we force the width to 100% and have this padding instead of just setting the width correctly in setInputWidth?

roblourens added a commit that referenced this pull request Feb 19, 2019
@roblourens
Copy link
Member

I removed setInputWidth because it actually didn't trigger when the find widget is resized, fyi @rebornix. But all the find inputs are sized the same way now at least.

sandy081 pushed a commit to vldmrkl/vscode that referenced this pull request Feb 22, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find input - Too much padding on markdown rendered tab
3 participants