cmd+down doesn't work when "workbench.list.openMode": "doubleClick" is set

[Tyriar]

Found in #68018

[Tyriar]

@roblourens maybe I'm doing something wrong but I removed all my settings and keybindings, searched something and now pressing cmd+down and cmd+return when focus is on a search result and it's doing nothing. Am I thinking right in that this should do the same thing as cmd+1? (since a preview editor will be opened)

This happens when both doubleClick and singleClick are set.

[roblourens]

@joaomoreno this is from 3946e32

It sounds right to not trigger onDidChangeSelection when the selection did not actually change, but we can select a selected element to make different things happen.

Similar, select an element in the file explorer then alt+click. It should open to the side (on mac) now it does nothing.

[roblourens]

Maybe the same, "go to definition" on something with multiple definitions (like the onDidChangeSelection event) and the first item in the peek tree is selected but it no longer navigates to that item right away.

[isidorn]

Feels like a duplicate of #69284
Leaving up to @joaomoreno to decide if to close as dupe.

[joaomoreno]

It was hard to understand what is the issue here, since I didn't know what Enter should do in that case. After testing stable, I verified that Enter should open and focus the editor. I've pushed a fix for that.

This happens when both doubleClick and singleClick are set.

@Tyriar Correct. Even in stable. My fix should cover that as well.

Maybe the same, "go to definition" on something with multiple definitions (like the onDidChangeSelection event) and the first item in the peek tree is selected but it no longer navigates to that item right away.

Can't repro that any more, maybe got fixed today with my other changes.