Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable: relativeFile posix or not? #68524

Closed
bpasero opened this issue Feb 12, 2019 · 4 comments
Closed

Variable: relativeFile posix or not? #68524

bpasero opened this issue Feb 12, 2019 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@bpasero
Copy link
Member

bpasero commented Feb 12, 2019

While adopting our new path library I noticed that relativeFile seems to be returning file paths with slash. The path returned now will use backslash if on Windows which is probably the right behaviour, but I wanted to fyi. We currently have no helper to convert a Windows path into a Posix path because it looks like path.posix.normalize() will actually preserve backslash.

//cc @dbaeumer @alexr00

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 12, 2019
@pbricout
Copy link

I also have an issue on Windows as it seems that it now return backslashes instead of forward slashes, this seems to be recent regression from this issue:
#40256
According to this issue forward slashes should be used on all OSes.
Doing this on windows, when the shell is bash is failing:

        {
            "label": "echo",
            "type": "shell",
            "command": "echo ${relativeFile}",
            "problemMatcher": []
        },

Will show abc instead of a/b/c.

@weinand
Copy link
Contributor

weinand commented Mar 22, 2019

@isidorn could you please link this issue to the other issue.

@pbricout
Copy link

I have create this issue which is related I think:
#70926

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2019

Dup of #70050 (comment)

@isidorn isidorn closed this as completed Mar 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants