Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit need for node/electron-browser in workbench/contrib/watermark #69117

Closed
bpasero opened this issue Feb 21, 2019 · 2 comments
Closed

Revisit need for node/electron-browser in workbench/contrib/watermark #69117

bpasero opened this issue Feb 21, 2019 · 2 comments
Assignees
@chrmarti
Labels
debt Code quality issues
Milestone
March 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 21, 2019

Refs #68302

I am not sure why src/vs/workbench/contrib/watermark has to have most of its files in electron-browser land. Please consider lifting this to browser if possible.

If there is something blocking this task, speak up and we need to think about introducing new services as needed.
@bpasero bpasero added the debt Code quality issues label Feb 21, 2019
@bpasero bpasero mentioned this issue Feb 21, 2019
Closed
17 tasks
@chrmarti
Copy link
Contributor

chrmarti commented Mar 4, 2019

@bpasero It only references OpenRecentAction.ID. I can inline that and use CommandRegistry.getCommand() to check if the command exists to avoid the dependency.

@bpasero
Copy link
Member Author

bpasero commented Mar 4, 2019

@bpasero wouldn't that result in a link on the welcome page that possibly does not work if the command is not there?

@microsoft microsoft deleted a comment from chrmarti Mar 4, 2019
@chrmarti chrmarti added this to the March 2019 milestone Mar 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2019
Development

No branches or pull requests
2 participants
@bpasero @chrmarti