Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributed action is not visible when group is not provided #69340

Closed
sandy081 opened this issue Feb 25, 2019 · 2 comments
Closed

Contributed action is not visible when group is not provided #69340

sandy081 opened this issue Feb 25, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #69196

"menus": {
			"debug/toolbar": [
				{
					"command": "test.restartDebug",
					"when": "debugType == node2"
				}
			]
		}

Command is not there anywhere in the toolbar. There should be some assistance to say that group is mandatory or by default show it in the tool bar?

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 25, 2019
@isidorn isidorn added this to the February 2019 milestone Feb 25, 2019
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Feb 25, 2019
@sandy081 sandy081 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Feb 26, 2019
@sandy081 sandy081 reopened this Feb 26, 2019
@sandy081
Copy link
Member Author

When I provide the group, the contributed action is show at the beginning.

image

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

@sandy081 great catch, thanks!

@octref octref added verified Verification succeeded and removed verification-found Issue verification failed labels Feb 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants