Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem view padding is inconsistent #69382

Closed
Tyriar opened this issue Feb 25, 2019 · 8 comments
Closed

Problem view padding is inconsistent #69382

Tyriar opened this issue Feb 25, 2019 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-error-widget polish Cleanup and polish issue

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2019

#69204

The top and bottom padding is inconsistent.

image

Looks like it's related to "invisible" items inside the body:

image

Version: 1.32.0-insider (user setup)
Commit: 393b48d
Date: 2019-02-25T01:34:48.785Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18841

@Tyriar Tyriar added the polish Cleanup and polish issue label Feb 25, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug editor-error-widget labels Feb 25, 2019
@sandy081 sandy081 added this to the February 2019 milestone Feb 25, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Feb 25, 2019

Also part of this, the scrollbar is hidden:

image

@sandy081
Copy link
Member

Fixed the scroll bar and focus issues. But it is hard to have consistent padding because it involves computing height using number of lines. Actually this looks same also before and the difference in padding is not so much to consider.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 26, 2019

@sandy081 I beg to differ with the difference in padding, it makes it look sloppy to me. If we can only show the padding if the scroll bar is needed that would be best like in #69391

@sandy081
Copy link
Member

sandy081 commented Feb 26, 2019

@Tyriar This is how it looks with and without a link. I don't see any sloppiness

image

image

@Tyriar
Copy link
Member Author

Tyriar commented Feb 26, 2019

@sandy081 the bottom padding of the container should match the top padding of the container, just like in the second screenshot?

@roblourens
Copy link
Member

I'm guessing this should be reopened?

I also spun another issue off this: #69495

@roblourens roblourens reopened this Feb 27, 2019
@sandy081
Copy link
Member

Since this is not a regression, moving this to March

@sandy081 sandy081 modified the milestones: February 2019, March 2019 Feb 27, 2019
@sandy081
Copy link
Member

Sorry @Tyriar. Looked into it again to make the padding symmetric. But I am sorry to say this need bigger changes to peek widget which I am not willing to do for the value it gives. Moreover it is like this from beginning. Hence closing this as wont fix.

@sandy081 sandy081 removed this from the March 2019 milestone Mar 20, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-error-widget polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants