Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flashing red status on the Outline view #69406

Closed
octref opened this issue Feb 25, 2019 · 4 comments
Closed

Flashing red status on the Outline view #69406

octref opened this issue Feb 25, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Feb 25, 2019

Testing #69299:

Have this SCSS, | is cusor:

.foo {
  .foobar {
|

.foo {}

Press enter, you see flashing red:

flash

@jrieken jrieken added this to the February 2019 milestone Feb 26, 2019
@jrieken jrieken added breadcrumbs bug Issue identified by VS Code Team member as probable bug labels Feb 26, 2019
@jrieken
Copy link
Member

jrieken commented Feb 26, 2019

Same in 1.31.x, not a regression, still unhappy. The challenge is that markers are matched at the time of editing and later (after the edit) being updated. That causes the flicker

@jrieken jrieken modified the milestones: February 2019, March 2019 Feb 26, 2019
@jrieken
Copy link
Member

jrieken commented Feb 26, 2019

Moving to March. This is actually tricky because I have an updated outline model, but a "stale" marker model. Checking the markers means that flash completely and I think that actually worst (see gif). We can consider delaying the update a little more, e.g optimistically wait a little for a markers change event.

feb-26-2019 12-28-59

@jrieken jrieken added outline Source outline view issues and removed breadcrumbs labels Feb 26, 2019
@jrieken jrieken closed this as completed in e8e7703 Mar 5, 2019
@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2019
@alexr00
Copy link
Member

alexr00 commented Mar 27, 2019

I'm not sure how to verify this. I can repro on stable, but in insiders the whole outline is red so there is no opportunity for it to flash red.

@jrieken
Copy link
Member

jrieken commented Mar 27, 2019

Yeah, that's already it. When there is no more flashing then everything is good

@octref octref added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Mar 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants