Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"sidebar" has inconsistent spelling in various keyindings conditions #69589

Closed
matklad opened this issue Feb 28, 2019 · 5 comments
Closed

"sidebar" has inconsistent spelling in various keyindings conditions #69589

matklad opened this issue Feb 28, 2019 · 5 comments
Assignees
Labels
debt Code quality issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@matklad
Copy link

matklad commented Feb 28, 2019

sidebarVisible | Side Bar is displayed.
sideBarFocus | Side Bar has focus.

from https://code.visualstudio.com/docs/getstarted/keybindings#_when-clause-contexts

I think we should make an alias, sidebarFocus for sideBarFocus and deprecate the latter

Version: 1.31.1
Commit: 1b8e8302e405050205e69b59abb3559592bb9e60
Date: 2019-02-12T02:19:29.629Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Linux x64 4.14.103
@vscodebot
Copy link

vscodebot bot commented Feb 28, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero bpasero assigned isidorn and unassigned bpasero Mar 1, 2019
@isidorn isidorn added the debt Code quality issues label Mar 1, 2019
@isidorn isidorn added this to the March 2019 milestone Mar 1, 2019
@isidorn isidorn added the feature-request Request for new features or functionality label Mar 6, 2019
@isidorn isidorn closed this as completed in df93a37 Mar 6, 2019
@isidorn
Copy link
Contributor

isidorn commented Mar 6, 2019

Since we have Side Bar everywhere in the UX I decided to deprecate sidebarVisible and introduce sideBarVisible
sidebarVisible will still be supported in the march release, but in the next one we will remove it.
Marking this as feature-request as a reminder to put this into release notes.

@matklad
Copy link
Author

matklad commented Mar 6, 2019

@isidorn it might be a good idea to looks for other things whihc might use the wrong spelling. Ther's at least workbench.action.toggleSidebarVisibility

@isidorn
Copy link
Contributor

isidorn commented Mar 6, 2019

You are right.
But that one I will not change. Converting command ids is a pain, and we have much wors command names than that.

@weinand weinand added the verification-needed Verification of issue is requested label Mar 26, 2019
@octref octref added the verified Verification succeeded label Mar 26, 2019
@octref
Copy link
Contributor

octref commented Mar 26, 2019

@isidorn Verified, but please update vscode-docs too.

@isidorn isidorn added the release-notes Release notes issues label Mar 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants