Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminals: hasChildProcesses should not run sync #69859

Closed
bpasero opened this issue Mar 5, 2019 · 0 comments
Closed

Terminals: hasChildProcesses should not run sync #69859

bpasero opened this issue Mar 5, 2019 · 0 comments
Assignees
@weinand
Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
October 2019

Comments

@bpasero
Copy link
Member

bpasero commented Mar 5, 2019 •
edited

We typically stay away from sync node API which blocks the renderer from executing and use async instead. Please check if hasChildProcesses really needs to be async or if callers already run in a promise context.
@bpasero bpasero added the debt Code quality issues label Mar 5, 2019
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues and removed debug Debug viewlet, configurations, breakpoints, adapter issues labels Oct 15, 2019
@weinand weinand added this to the October 2019 milestone Oct 15, 2019
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debt Code quality issues debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
2 participants
@bpasero @weinand