Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved files are opened in two windows when reopening vscode. #70180

Merged
merged 2 commits into from Mar 12, 2019
Merged

Unsaved files are opened in two windows when reopening vscode. #70180

merged 2 commits into from Mar 12, 2019

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Mar 10, 2019

Fixes #70006

@aeschli aeschli added this to the February 2019 Recovery 2 milestone Mar 10, 2019
@aeschli aeschli self-assigned this Mar 10, 2019
@aeschli aeschli requested a review from bpasero March 10, 2019 21:02
@aeschli aeschli mentioned this pull request Mar 10, 2019
Merged
bpasero
bpasero reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeschli using arrays.distinct(emptyToRestore, info => info.backupFolder || '') means that any empty window without backupFolder will be considered equal to each other. Is that intentional? Does that even happen?

@bpasero bpasero mentioned this pull request Mar 12, 2019
Closed
@bpasero bpasero merged commit 937ba07 into release/1.32 Mar 12, 2019
@aeschli
Copy link
Contributor Author

aeschli commented Mar 12, 2019 •
edited

@bpasero Sorry for the late answer. From how I understand it, multiple entries with info.backupFolder === undefined doesn't exist at that point. I had to add the || '' check for strict null validation.

@bpasero
Copy link
Member

bpasero commented Mar 13, 2019

@aeschli yeah, I filed #70322 as follow up

@egamma egamma removed this from the February 2019 Recovery 2 milestone Mar 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
@aeschli aeschli deleted the aeschli/fix-70179-maintenance branch June 29, 2020 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aeschli @bpasero @egamma