Adopt search viewlet to align with ViewsViewlet #70224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roblourens Adopted Search viewlet to align with ViewsViewlet. Please take a look. |
|
I think it's different because it's the only viewlet that also must exist in the Panel. This doesn't break that does it? |
|
No, it is different because it does not have custom views. Yes, search view exists in both sidebar and panel but not the viewlet. I refactored and separated viewlet, view and panel parts and made sure it does not break when search view is located in sidebar or panel. |
roblourens
approved these changes
Mar 11, 2019
|
This looks good. @sandy081 nice job! |
isidorn
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #70221