Add option to hide git sync button in status bar #70536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This PR adds the option `git.statusBarSync.enabled` which when set to `false` will hide the `SyncStatusBar` icon that is, by default, visible in the status bar.
| this.state = { ... this.state, isEnabled: true }; | ||
| } else { | ||
| this.state = { ... this.state, isEnabled: false }; | ||
| } |
There was a problem hiding this comment.
@joshleeb are you think about this suggestion? Without this one if isn't simpler?
this.state = { ... this.state, isEnabled: isEnabled };
|
Is there an issue for this? |
|
@roblourens apologies for not creating an issue. I thought it would be a minor enough change not to warrant one. I've created an issue and linked to it in the PR description. |
|
Renamed setting to |
|
Thanks! 🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option
git.statusBarSync.enabledwhich when set tofalsewill hide theSyncStatusBaricon that is, by default, visible in the status bar.Resolves #70604