process#findExecutable() should not use sync fs

[bpasero]

Looks like win32.findExecutable is being used from the renderer and has 3 occurrences of fs.existsSync() that should use the async variant instead. It should be possible to just return a promise from this method.

Feel free to move forward if you are not the owner of this method, I just went by git history.

[bpasero]

@dbaeumer looks like I filed this in 2017 already (#34425). Is there a technical problem resolving this?

[dbaeumer]

No technincal problem. I even think that this has no super high priority right now since the whole code needs to move out of the renderer anyways. This is independent of whether it is sync or async.

[bpasero]

@dbaeumer oh ok, if it moves out of the renderer into the extension host than its less critical. Though I still think sync API should not be used if possible (I know we are not very good in other processes besides the renderer).