Nested submodules break git GUI

[dmcilvaney]

Issue Type: Bug

Adding a submodule, which itself contains additional submodules, causes the git GUI to fail reporting "No source control providers registered". The git CLI continues to function as expected. Looks to be independent of issue #37947.

Expected result: Git GUI shows at least the root repository and first layer of submodules (nested submodules would be nice to have, but preserving existing functionality would be sufficient)

Repro using the OpenSSL repo (it is not unique to OSSL however). Tested using WSL/bash.

#Create folder and open it in VSCode
mkdir submodule_issue_repro; cd submodule_issue_repro; code .
#Create git repo and add 1st layer submodule
git init
mkdir external; pushd external; git submodule add https://github.com/openssl/openssl.git; popd
git status

#VSCode git GUI is available and agrees with git CLI, shows the first layer submodule

#Initialize the second layer of submodules
pushd external/openssl; git submodule init; git submodule update; popd
git status

#VSCode git GUI will now show "No source control providers registered".

VS Code version: Code 1.32.3 (a3db5be, 2019-03-14T23:43:35.476Z)
OS version: Windows_NT x64 10.0.18859

System Info

Item	Value
CPUs	Intel(R) Xeon(R) CPU E5-1650 v4 @ 3.60GHz (12 x 3592)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.92GB (19.73GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (3)

Extension	Author (truncated)	Version
python	ms-	2019.2.5558
cpptools	ms-	0.21.0
line-endings	ste	1.0.3

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Git: Support submodule management (#52700)
• SCM: Differentiate between submodules and normal repos (#43951)
• Foldername displayed instead of submodule name in git window (#59022)
• Can't detect git repository by opening a symlink to a file within it (#45919)
• Auto update submodules (#56249)

[joaomoreno]

Can you test this using Git for Windows, which is the only one we support?

[dmcilvaney]

Worked with Git for Windows with some caveats (on the Git side).

We usually run with bash as our default terminal, and a repo modified via the bash terminal in VSCode does not work since there seems to be an incompatibility between git on bash, and git for Windows.

It apears that if the submodules are added from Git for Windows both bash and Windows can get status successfully, but if the submodules are added from bash, git status fails in Windows (hence breaking VSCode).