Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error/warning confusion with unused imports #71067

Closed
jrieken opened this issue Mar 25, 2019 · 0 comments
Closed

error/warning confusion with unused imports #71067

jrieken opened this issue Mar 25, 2019 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2019

This is weird and we should decide if we show an error or a warning, not both

  • unused import with single imported symbol -> warning
  • unused import with multiple imported symbols -> error

Screenshot 2019-03-25 at 12 26 27

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 2, 2019
@mjbvz mjbvz added this to the April 2019 milestone Apr 3, 2019
@mjbvz mjbvz added javascript JavaScript support issues typescript Typescript support issues labels Apr 3, 2019
@mjbvz mjbvz closed this as completed in e50c257 Apr 3, 2019
@jrieken jrieken added the verified Verification succeeded label May 7, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants