Expose uriScheme through vscode.env #71397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Apr 1, 2019
src/vs/vscode.proposed.d.ts
Outdated
| /** | ||
| * The url protocol of the editor, like 'vscode', 'vscode-insiders'. | ||
| */ | ||
| export const urlProtocol: string; |
There was a problem hiding this comment.
Not sure, the thing is called uri-handler, now we talk about url protocol. What's correct? Why being inconsistent? Also protocol vs scheme?
There was a problem hiding this comment.
We should also update this https://github.com/Microsoft/vscode/blob/a3fc8198a7a274b580e8fbf7664e13a8bd8df647/src/vs/vscode.d.ts#L6643
There was a problem hiding this comment.
We should call it uriScheme as uriHandler stands for the application.
rebornix
changed the title
|
As we discussed on API syncup, we are going to use the name |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when extensions attempt to construct a callback url for themselves, they can only guess by checking the appName, but we should be smart enough to expose this information, for example
vscode,code-oss,vscode-exoloration.