Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] Debounce color theme selection #71616

Closed
gacardinal opened this issue Apr 2, 2019 · 3 comments
Closed

[themes] Debounce color theme selection #71616

gacardinal opened this issue Apr 2, 2019 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@gacardinal
Copy link

Background

Like a lot of developers, I find myself developing in multiple languages and environments and and I have adopted different color themes that I prefer for different languages. So I, for instance, like to use the Monokai theme when I write JavaScript code but prefer to use something like Material Theme Dark when I write C# code. The point here is because I like to use different themes for different languages, I find myself switching color themes often (pretty much as often as I change workspace).

However, the process of changing color theme can be tedious when there are a lot of color themes installed, (by a lot here I mean like 14, including the default ones) because it is sometimes necessary to scroll trough the entire list of color themes to access the desired one. This becomes tedious because when using the keyboard arrows, which I do because I open the 'color theme selector' by pressing Ctrl + K T so it's convenient to not use the mouse, the editor previews the highlighted color theme every time an arrow key is pressed which takes some time and makes it somewhat long to select a desired color theme.

Current behavior

As of now, the 'color theme selector' previews the selected color theme every time a new one is selected using the keyboard arrow keys.

Somewhat of a workaround

One possible way to partly counter this is to keep pressing an arrow key until the cursor scrolls to the desired color theme and try to 'snipe' it but this is no easy task and in my opinion, not adequate.

Proposal

I would like to suggest that the 'color theme selector' be 'debounced'. I use the term 'debouncing' for lack of a better term but what I mean by 'debouncing' is that the 'color theme selector' should not immediately attempt to preview the selected color theme when the selection changes and instead wait a given interval (say 300ms) before previewing the selected color theme, allowing someone to rapidly scroll trough the list of color themes without having to wait for the editor to have previewed each one.

Any thoughts?

@vscodebot vscodebot bot added the themes Color theme issues label Apr 2, 2019
@gacardinal gacardinal changed the title Debounce color theme selection [Feature Request] Debounce color theme selection Apr 2, 2019
@aeschli aeschli changed the title [Feature Request] Debounce color theme selection [themes] Debounce color theme selection Apr 3, 2019
@aeschli aeschli added the feature-request Request for new features or functionality label Apr 3, 2019
@aeschli aeschli added this to the Backlog milestone Apr 3, 2019
@aeschli aeschli modified the milestones: Backlog, October 2019 Oct 10, 2019
@aeschli aeschli added the verification-needed Verification of issue is requested label Oct 29, 2019
@aeschli
Copy link
Contributor

aeschli commented Oct 29, 2019

To verify:

  • open the color or file icon theme selection dialog (Ctrl + K Ctrl +T)
  • quickly cursor down will not reveal the theme, only after typing stops.

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2019

@Gaboik the debouncing is a nice addition but FYI you might be better off typing to search for the theme, also you can disable built-in themes that you never plan to use to shorten the list:

image

@Tyriar Tyriar added the verified Verification succeeded label Oct 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants