Join Lines Redesigned #71678
Closed
Join Lines Redesigned #71678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
added
editor-commands
rheh
reviewed
Nov 9, 2020
| } | ||
| const range = new Range(line, model.getLineMaxColumn(line) - whitespaceAtEnd[0].length, line + 1, model.getLineFirstNonWhitespaceColumn(line + 1)); | ||
| if (model.getLineContent(line).length > 0) { |
| } | ||
| private _getLinesToJoin(editor: IActiveCodeEditor): IJoinLinesOperation[] { | ||
| // Construct Join operations | ||
| let operations: IJoinLinesOperation[] = editor.getSelections().map((s) => { |
| return new Selection(previousValue.startLineNumber, previousValue.startColumn, currentValue.endLineNumber, currentValue.endColumn); | ||
| } | ||
| let endLineNumber = s.endLineNumber; | ||
| if (s.startLineNumber < s.endLineNumber && s.endColumn === 1) { |
There was a problem hiding this comment.
What is the significance of the magic number 1? Could this is improved by adding a name constant to reveal what 1 means?
| } | ||
| private _getLinesToJoin(editor: IActiveCodeEditor): IJoinLinesOperation[] { | ||
| // Construct Join operations | ||
| let operations: IJoinLinesOperation[] = editor.getSelections().map((s) => { |
| if (model === null) { | ||
| return; | ||
| // Merge Join operations which are adjacent or overlapping | ||
| let mergedOperations: IJoinLinesOperation[] = []; |
| } | ||
|
|
||
| lineOffset += deleteSelection.endLineNumber - deleteSelection.startLineNumber; | ||
| let start = model.getLineFirstNonWhitespaceColumn(startLineNumber); |
| let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn; | ||
| let removeLines = this._getLinesToJoin(editor); | ||
| let ops: IIdentifiedSingleEditOperation[] = []; | ||
| let conString: String[] = []; |
| let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn; | ||
| let removeLines = this._getLinesToJoin(editor); | ||
| let ops: IIdentifiedSingleEditOperation[] = []; | ||
| let conString: String[] = []; |
There was a problem hiding this comment.
When shortening names it makes it harder to understand what it is used for? What is con? Would naming the variable more clearly make it more readable?
| editor.pushUndoStop(); | ||
| editor.executeEdits(this.id, edits, endCursorState); | ||
| editor.executeEdits(this.id, ops, cursorState); |
There was a problem hiding this comment.
This function is now rather large. Can be be broken down into smaller private functions?
|
I would recommend to implement this experience in an extension. Thanks for your contribution though ❤️ |
rebornix
added
the
*extension-candidate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #64655.
It redesigns multi-cursor Join Lines to allow for multiple lines to be merged in.
Before:
Examples:
As a note, it will merge in adjacent selections.