toggle problems shortcut

[jerrygreen]

It's not toggling back (not closing the "problems" view)

Versions

• VSCode Version: 1.32.3
• OS Version: macOS Mojave 10.14.3

Steps to Reproduce:

1. cmd + shift + m to toggle the view (it works)
2. cmd + shift + m to toggle it back / to close (it won't work)

Does this issue occur when all extensions are disabled?

Yes

[jerrygreen]

However, if I use a separate tab, "output" (cmd + shift + u) – it toggles back and forth

But cmd + shift + m is one-side toggle :(

[jwikman]

This has annoyed me as well.

Actually I think it's related to the behavior of the Problems panel. If there are no problems, the "problems" panel isn't focused on ctrl+shift+m. As soon as I got a problem this works as intended. You can see the focusing of the panel (or lack of it) by observing the border of that panel.

The panel is only hidden if it is focused as seen in src\vs\workbench\browser\panel.ts:

		if (this.isPanelFocused()) {
			this.layoutService.setPanelHidden(true);
		} else {
			this.panelService.openPanel(this.panelId, true);
		}

So I think the the solution would be to focus on the "problems" panel even if there are no problems.

[sandy081]

@jerrygreen Can you please check in your keybindings editor to which command ctrl+shift+m keybinding is associated to?

[jwikman]

@sandy081 I've got the default binding, with a similar experience as @jerrygreen
But I only experience this if the problems list is empty, don't know if @jerrygreen has this issue also when there are problems...

Keybinding:

{
  "key": "ctrl+shift+m",
  "command": "workbench.actions.view.problems"
}

[sandy081]

@jwikman I see following as default

Can you disable all extensions and check again?

[jerrygreen]

@sandy081 ofc:

Also, agree with @jwikman:

But I only experience this if the problems list is empty

[jwikman]

@jwikman I see following as default

Can you disable all extensions and check again?

@sandy081 if you right click and select copy you get the same result as me... I.e. I haven't changed any keybinding, I'm using the default ones. If you search for "workbench.actions.view.problems" in the code, you'll see that's the default command for that ctrl+shift+M.

So no surprises here: it's the same with all extensions disabled...

[sandy081]

Ok, will investigate why it is behaving differently when problems are empty.

[chrisjones-brack3t]

Also running into this issue and it's driving me a little mad.

[akshaal]

Quite annoying. Is there a workaround at the moment? It could have been possible to just call workbench.action.togglePanel when the problems panel is already visible, but it looks like there is no way to find out whether the problems panel is visible or not....