[folding] make max folding region limit configurable

[Lovecircle]

• VSCode Version: 1.32.1
• OS Version: Win7 x64

Steps to Reproduce:

1. Set in editor settings:
   "editor.folding": true, "editor.foldingStrategy": "indentation"

2. Open the attached file and go to line 43914 where folding stopped working.

test_ident.zip

3. Delete couple of blocks of code - folding starts working again.

Developer of folding extension "Explicit Folding" pointed out to me that there is a hard limit of 5000 foldings per file. If it is so than I guess this is not a bug report but a feature request for editor setting in order to increase this limit. In my case, folding stopped working in file with about 35000 lines - which is not that many.

Does this issue occur when all extensions are disabled?: Yes

[robcowart]

Is there any plan to address this? It is quickly becoming a show-stopper for us.

[gse4me]

Any news on this feature ?

[zahanm]

I looked through, and these look like the relevant spots where this limit is currently hardcoded

vscode/extensions/markdown-language-features/src/features/foldingProvider.ts

Line 11 in 9dd4f31

const rangeLimit = 5000;

vscode/src/vs/editor/contrib/folding/syntaxRangeProvider.ts

Line 14 in 9dd4f31

const MAX_FOLDING_REGIONS = 5000;

vscode/src/vs/editor/contrib/folding/indentRangeProvider.ts

Line 14 in 9dd4f31

const MAX_FOLDING_REGIONS_FOR_INDENT_LIMIT = 5000;

vscode/src/vs/workbench/contrib/notebook/browser/contrib/fold/foldingModel.ts

Line 203 in 9dd4f31

const newRegions = sanitizeRanges(rawFoldingRanges, 5000);

vscode/src/vs/editor/contrib/folding/folding.ts

Line 58 in 9dd4f31

static readonly MAX_FOLDING_REGIONS = 5000;

Making it configurable, similar to editor.largeFileOptimizations seems preferable. Though it is of course a "shoot yourself in the foot" situation.