New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect wording of Outline drawer default message #73213

Closed

BaluErtl opened this issue May 3, 2019 · 1 comment

Contributor

BaluErtl commented May 3, 2019

Steps to reproduce:

Open an editor tab for a file with a format that parser of Outline drawer supports (eg. .md, .php or .js).
Open another editor tab for a file with a format that parser of Outline drawer does not supports (eg. .yml or .twig).
While the latter editor tab is focused, the text in the Outline drawer reads:

"There are no editors open that can provide outline information."

I do feel that this wording can be considered a bit misleading: in opposition what is currently means, the real fact that there is (at least – in the above scenario – one) editor tab open, which holds data that Outline parser can understand. Although, it's unfocused currently, indeed.
Therefore I suggest wording something similar like this:

The currently focused editor can not provide outline information.

As far as I searched, this message line occurs in code at /src/vs/workbench/contrib/outline/browser/outlinePanel.ts at line :459

VSCode Version: 1.33.1
OS Version: 10.13.6 (17G6030)

The text was updated successfully, but these errors were encountered:

BaluErtl mentioned this issue

Incorrect wording of Outline drawer default message #73214

Merged

Contributor Author

BaluErtl commented May 3, 2019

This issue was created first before the PR, sorry. Can be closed/deleted.

BaluErtl closed this as completed

vscodebot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.