Update remote background defaults #73266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not super clean, as ACTIVITY_BAR_BADGE_BACKGROUND/FOREGROUND are designed for the activity bar and might not relate to colors on the status bar, but I guess it's save as the two colors (back and foreground) are designed to work together. I'd suggest to make a pass over all themes that we ship (not just the default one) and fill in explicit color values for the remote colors. |
aeschli
approved these changes
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the default colors for the remote background & foreground to inherit the colors from
activityBarBadge.backgroundandactivityBarBadge.foreground, while also defining the colors in our default theme (@jrieken originally suggested this). This works as a better default otherwise all themes will inherit the green (a graceful fallback) until themes designate a color for it.cc @bpasero @kieferrm