Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow empty string to be inserted... #73477

Merged
merged 1 commit into from
May 8, 2019
Merged

allow empty string to be inserted... #73477

merged 1 commit into from
May 8, 2019

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented May 8, 2019

This PR fixes #72728

@jrieken jrieken self-assigned this May 8, 2019
@jrieken jrieken requested a review from isidorn May 8, 2019 15:08
@jrieken jrieken mentioned this pull request May 8, 2019
Closed
@isidorn
Copy link
Contributor

isidorn commented May 8, 2019

lgtm
verified this fixes the issue

@isidorn isidorn added this to the April 2019 milestone May 8, 2019
@jrieken jrieken merged commit 9cedc68 into master May 8, 2019
@jrieken jrieken deleted the joh/72728 branch May 8, 2019 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isidorn isidorn isidorn approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
April 2019
Development

Successfully merging this pull request may close these issues.

Re-adding a configuration in launch.json doesn't work
2 participants
@jrieken @isidorn