Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemProvider: Switching file in the editor causes explorer incomplete sync #74006

Closed
plus- opened this issue May 20, 2019 · 6 comments
Closed
Assignees
Labels
file-explorer Explorer widget issues info-needed Issue requires more information from poster *out-of-scope Posted issue is not in scope of VS Code

Comments

@plus-
Copy link

plus- commented May 20, 2019

Version: 1.34.0 (user setup)
Commit: a622c65
Date: 2019-05-15T21:59:37.030Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

Steps to Reproduce:

  1. Implement a remote FileSystemProvider
  2. In the explorer browse and open 2 different files Apple & Banana
    Apple uri is like so scheme:/path/to/Apple
  3. After opening Banana go back to Apple from the editor title
  4. The explorer will update without the children from the top parent folder containing Apple (in above example path will be empty). All other folders still have their children.
  5. Also the "Refresh Explorer" button doesn't load that folder children.
  6. Closing all files from that folder in the editor will fix the previous issue.

It may be related to the logic behind highlightning the current file in the explorer.

@plus-
Copy link
Author

plus- commented May 21, 2019

I'm reopening this as I though it was an issue on my side but I have more information.

It happens only for the first folder defined in the vscode workspace, other folders works fine (although the current file is not highlighted in the explorer). If I switch around the remote filesystem in the workspace the issue is always happening on the first one defined.

I've checked the debugger and it only calls readDirectory for the first folder of the workspace when switching files in the editor.

You can test for yourself on this branch https://github.com/plus-/vscode-cmis/tree/sync-error
I've trimmed down the extension to the minimum

And open the following workspace (it just has one remote folder for simplicity but since the problem only happen on the first folder it's ok)

{
	"folders": [
		{
			"name": "Alfresco",
			"uri": "cmis://admin:admin@cmis.alfresco.com?ssl=1&base=cmisbrowser"
		}
	]
}

when you expand the parent remote folder, at the top there is a __vscode_example folder with some files (apple and banana) if you switch between them you will see the problem (it's not immediate as the operation is async).

@plus- plus- reopened this May 21, 2019
@plus-
Copy link
Author

plus- commented May 21, 2019

example

@isidorn
Copy link
Contributor

isidorn commented May 24, 2019

Got it. Looks like a duplicate of #73469
If you F1 > developer tools > console
Do you see some errors?

@isidorn isidorn added file-explorer Explorer widget issues info-needed Issue requires more information from poster labels May 24, 2019
@plus-
Copy link
Author

plus- commented May 24, 2019

No errors in the console.

@plus-
Copy link
Author

plus- commented Jul 9, 2019

I've noticed the bug still exist in the VSCode Insiders version. Switching tabs remove the opened folder from the explorer like before, however now the refresh sometimes works (about half the time), the opened folder will reappear.

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 9, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues info-needed Issue requires more information from poster *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

2 participants