Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks: consider to use status progress for "Building..." entry #74602

Closed
bpasero opened this issue May 30, 2019 · 1 comment
Closed

Tasks: consider to use status progress for "Building..." entry #74602

bpasero opened this issue May 30, 2019 · 1 comment
Assignees
@alexr00
Labels
debt Code quality issues tasks Task system issues workbench-status Status bar
Milestone
June 2019

Comments

@bpasero
Copy link
Member

bpasero commented May 30, 2019

Today there is a "Building..." label appearing around the problems entry when building a project. I think this originates from a time where we did not have support to show progress in the status bar.

before

I suggest to move this out of the problems marker and into the status progress facility via IProgressService.withProgress(ProgressLocation.Window)

//cc @dbaeumer
@bpasero bpasero added tasks Task system issues workbench-status Status bar labels May 30, 2019
@alexr00 alexr00 added the debt Code quality issues label May 31, 2019
@alexr00 alexr00 added this to the June 2019 milestone May 31, 2019
@dbaeumer
Copy link
Member

Makes sense to me.

@alexr00 alexr00 closed this as completed in 7d698b4 Jun 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
debt Code quality issues tasks Task system issues workbench-status Status bar
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
3 participants
@bpasero @dbaeumer @alexr00