Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize repository icon looks our of style #74978

Closed
isidorn opened this issue Jun 6, 2019 · 8 comments
Closed

Initialize repository icon looks our of style #74978

isidorn opened this issue Jun 6, 2019 · 8 comments
Assignees
Labels
icons-product Issues for in-product icons

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 6, 2019

Have a repository with no git source control. Open git viewlet -> notice the git icon. It looks out of place compared to the other lean icons imho. Though I would be interested what @joaomoreno thinks

I suggest to use the same recognisable git icon, just styled in a way that matches our theme better.
fyi @bpasero

Screenshot 2019-06-06 at 15 30 08

@miguelsolorio
Copy link
Contributor

Ah, I totally missed this icon. Thanks for catching that.

@miguelsolorio
Copy link
Contributor

So either we go with one of the branch/fork/repo icons like so:

image

or use their logo:
https://git-scm.com/downloads/logos

@joaomoreno thougts?

@isidorn
Copy link
Contributor Author

isidorn commented Jun 7, 2019

Since this is a source contorl tab and git is still not choosen we should not make any assumptions about the user going for git. He might choose tfs.
imho we should go with your proposed solution of using the same activity bar icon. Though I leave it up for @joaomoreno
btw he is on vacation so he will reply on Tuesady

@miguelsolorio miguelsolorio added the icons-product Issues for in-product icons label Jun 7, 2019
@miguelsolorio
Copy link
Contributor

We could alternately use a +:

image

@miguelsolorio
Copy link
Contributor

Went with the plus for now, we can change it later if think we find a better option.

@mittalyashu
Copy link

@misolori based on the current icon design pattern you can design a custom icon for git logo with an outline.

image

@miguelsolorio
Copy link
Contributor

@mittalyashu we need to provide an icon that applies to all SCM providers, not just git as there are many (tfs, svn, etc.):

image

@isidorn
Copy link
Contributor Author

isidorn commented Jun 10, 2019

@misoguy I like the plus.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
icons-product Issues for in-product icons
Projects
None yet
Development

No branches or pull requests

3 participants