The new application icon lacks resolution on HiDPI systems

[idmadj]

• VSCode Version: 1.35.0
• OS Version: Win 10 Pro x64 1809 build 17763.503

Steps to Reproduce:

1. Pin VSCode to the Start menu on a HiDPI system (for instance at 3840×2160 resolution with 200% custom scaling);
2. Open the start menu and observe that the icon appears blurry due to insufficient resolution

The VSCode and VSCode Insider icons appear blurry and suffer from upscaling artefacts:

[miguelsolorio]

We added high-resolution version of the logos in the June release (per the Win 10 icon size guidance) so this should be fixed by now. Here's a preview from a HiDPI screen:

[idmadj]

Hey @misolori,
I filed this issue in June. Sounds like the higher res icons may be the reason we're seeing scaling artefacts as Windows is using them now and applying poor downscaling. There's still some significant jaggedness visible on the top picture you posted. To me it looks like nearest-neighbor downscaling + some fuzziness. It's especially apparent on the diagonals. Maybe providing more intermediate icon sizes would help.

Here's a quick mockup of how it looks now (left) vs what it should look like:

Bottom picture looks great.

[miguelsolorio]

Hmm...let me investigate this some more. Digging into this, it appears that the tile icons are different from the .ico icons, which are the ones that contain the HiDPI icons. Not sure if they support higher resolutions but will take a look.