Use MutableDisposable for managing editorStatus items #75378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MutableDisposable` class helps manage a disposable value that may change over time. I noticed that editorStatus was currently manually managing its `IStatusbarEntryAccessor` elements and think `MutableDisposable` can help simplify the code and prevent mistakes, such as forgetting to dispose of a property before re-assigning it
bpasero
approved these changes
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MutableDisposableclass helps manage a disposable value that may change over time. I noticed that editorStatus is manually managing its disposableIStatusbarEntryAccessorelements and thinkMutableDisposablecan help here. The class prevents mistakes such as forgetting to dispose of a property before re-assigning it. It also lets us use_registerto ensure these values are cleaned up properly when the class is disposed of