Icon align on mac on "Open With" dialog

[butuzov]

• VSCode Version: 1.35.0 (1.35.0)
• OS Version: Mac - High Sierra 10.13.6 (17G6030)

Steps to Reproduce:

1. Click on associated file type and open "Open With" dialog

As you see - icon isn't really aligned with other icons.

[miguelsolorio]

I'm not seeing this reproduce on Mojave (10.14.3)

@bpasero @deepak1556 does this sound like an electron or mac bug?

[bpasero]

Sorry I am not sure, @joaomoreno maybe? This comes from the Info.plist afaik?

[miguelsolorio]

I've got a High Sierra machine at home and interestingly enough this only happens on the stable build:

[miguelsolorio]

Assigning to @deepak1556 to see if this is an electron related issue. I have a High Sierra machine if you want me to test anything.

[bpasero]

I kind of doubt this could be Electron related. Certainly could be an upstream issue or a bug with our icon or even Info.plist configuration. If someone has ideas, welcome.

[miguelsolorio]

Just inspected the two .icns (I extracted the pngs) files for Stable and Insiders and they are identical:

[bpasero]

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to the code. As such, I will go ahead and close it. If you can identify the component that is causing the issue, please report it upstream:

• for UI, OS integration: https://github.com/electron/electron
• for Rendering: https://bugs.chromium.org/p/chromium/issues/list
• for file IO: https://github.com/nodejs/node

Thanks for understanding.