Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline should forget previous selection #75692

Closed
ghost opened this issue Jun 18, 2019 · 5 comments
Closed

Outline should forget previous selection #75692

ghost opened this issue Jun 18, 2019 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality outline Source outline view issues

Comments

@ghost
Copy link

ghost commented Jun 18, 2019

Right now, if I select an item in the outline, the editor scrolls to that item (good 馃憤).

Suppose I then scroll manually to another part of the code (taking the input cursor with me). Logically, that outline entry is no longer "active", there's no real sense in which I've selected it. If I then try to click on the same entry in the outline again to return to it, nothing happens (apparently because the outline considers that item "selected" already). I have to click another outline item, then return to the one I want.

Proposed solutions:

  • either have the outline "deselect" the currently selected item when the editing cursor moves off that line/out of that function/whatever;

  • or simply don't persist the outline with a "selected" state at all, outline entries simply act as buttons (there's no context menu on outline entries, or anything else that seems to benefit from a specific item being memorised as "selected"

@vscodebot
Copy link

vscodebot bot commented Jun 18, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken
Copy link
Member

jrieken commented Jun 19, 2019

How about using the 'Follow Cursor' feature?

Screenshot 2019-06-19 at 09 47 12

@jrieken jrieken added outline Source outline view issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 19, 2019
@ghost
Copy link
Author

ghost commented Jun 19, 2019

@jrieken that only seems to work if my cursor moves to the specific line of another definition (e.g., the signature of a function), not if I move to anywhere else in the file (e.g., the body of a function)

@jrieken jrieken added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 19, 2019
@jrieken
Copy link
Member

jrieken commented Jun 19, 2019

Understood

@jrieken
Copy link
Member

jrieken commented Oct 2, 2019

fix via #81323

@jrieken jrieken closed this as completed Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality outline Source outline view issues
Projects
None yet
Development

No branches or pull requests

1 participant