Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect whitespaces rendering\wrapping #75704

Closed
Iipal opened this issue Jun 18, 2019 · 6 comments
Closed

Incorrect whitespaces rendering\wrapping #75704

Iipal opened this issue Jun 18, 2019 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-indent-guides Editor indentation guides editor-wrapping Editor line wrapping issues verified Verification succeeded
Milestone

Comments

@Iipal
Copy link

Iipal commented Jun 18, 2019

  • VSCode Version: 1.36.0-insider
  • OS Version: MacOS Mojave 10.14.5

Screen Shot 2019-06-18 at 5 20 48 PM

@vscodebot
Copy link

vscodebot bot commented Jun 18, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor-wrapping Editor line wrapping issues label Jun 18, 2019
@alexdima
Copy link
Member

alexdima commented Aug 5, 2019

@Iipal Could you please paste the text here or attach the file here, I am not 100% what I am looking at...

@alexdima alexdima added the info-needed Issue requires more information from poster label Aug 5, 2019
@Iipal
Copy link
Author

Iipal commented Aug 7, 2019

@alexandrudima it's a lot of tabs before i = ~0;

void	foo(void)
{
	int	i;

																																																	i = ~0;
}

@alexdima
Copy link
Member

alexdima commented Aug 7, 2019

Ok, steps to reproduce:
Have the following settings and open the above file:

"editor.wordWrap": "wordWrapColumn",
"editor.wordWrapColumn": 50,
"editor.rulers": [50]

This file + these settings causes wrapping to occur within the line leading whitespace, which confuses the indentation guides:

image

@alexdima alexdima added editor-indent-guides Editor indentation guides bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Aug 7, 2019
@Iipal
Copy link
Author

Iipal commented Aug 7, 2019

@alexandrudima yeap, exactly what you says. Sorry for didn't added steps to reproduce, my fail

@alexdima
Copy link
Member

alexdima commented Aug 7, 2019

Pushed a change where we now limit the rendering of indent guides to the wrapping column:

image

@alexdima alexdima added this to the August 2019 milestone Aug 7, 2019
@aeschli aeschli added the verified Verification succeeded label Aug 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-indent-guides Editor indentation guides editor-wrapping Editor line wrapping issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants