Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to cursor: doesn't show a warning if jumping to invalid cursor location #76079

Closed
dbaeumer opened this issue Jun 25, 2019 · 6 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #76008

Title says it all.

@dbaeumer
Copy link
Member Author

To reproduce try to jump to the end of the file.

@isidorn isidorn added this to the June 2019 milestone Jun 25, 2019
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 25, 2019
@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2019

Also saw this trying to jump to inside Another:

image

@isidorn
Copy link
Contributor

isidorn commented Jun 26, 2019

@gregg-miskelly it seems like the C# adapter is returing gotoTargets for the end of the file position. This appears to be wrong. Should we move this issue to the C# extension?
Also is it possible that you sent me via email a new version of your extension which does not require a handshake so I can eaisly test this when running vscode out of source? Thank you

@isidorn isidorn modified the milestones: June 2019, July 2019 Jun 26, 2019
@gregg-miskelly
Copy link
Member

@isidorn I think you fixed this already in #75578.

The design of gotoTargets is that it will return all possibly valid targets -- any source location that has associated code will get a target. Then if you actually try to go to that target, now we have enough context to know that that location is invalid, and we will fail to the goto request. With your fix, I believe everything will now work properly as the test case in this issue is essentially identical to my test case when I validated your fix.

If you still want a debug build, I am happy to provide.

@isidorn
Copy link
Contributor

isidorn commented Jun 27, 2019

@gregg-miskelly thanks. Yeah a debug build would be great for future stuff.

@isidorn isidorn modified the milestones: July 2019, On Deck Jun 27, 2019
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Oct 9, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 9, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

4 participants