Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing previous version action is not working for renamed extensions #76253

Open
sandy081 opened this issue Jun 27, 2019 · 6 comments
Open
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug marketplace Microsoft VS Code Marketplace issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@sandy081
Copy link
Member

Ref #76211
From @EricJizbaMSFT

As I side note, I tried to install the old version directly from VS Code (instead of from a vsix), but no luck.
Screen Shot 2019-06-27 at 8 37 47 AM
Screen Shot 2019-06-27 at 8 34 37 AM
Screen Shot 2019-06-27 at 8 34 22 AM

@sandy081 sandy081 self-assigned this Jun 27, 2019
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Jun 27, 2019
@sandy081 sandy081 added this to the July 2019 milestone Jun 27, 2019
@sandy081
Copy link
Member Author

@kesane-msft It happens because the properties of old extension (with old name) are not available when querying from marketplace. Are they get deleted when extension gets renamed?

@sandy081 sandy081 added the marketplace Microsoft VS Code Marketplace issues label Jun 28, 2019
@kesane-msft
Copy link

@sandy081 yes. During the rename, we basically just change the latest version of the extension.

@sandy081
Copy link
Member Author

Sorry if I am not clear -

I run the query with new name and in the query I request for all versions.
In the result, I get all versions of the extension but only those versions with new name has properties, remaining has missing properties.

@kesane-msft
Copy link

@sandy081 - that's because we don't migrate the properties for the older versions.

@sandy081
Copy link
Member Author

sandy081 commented Jul 1, 2019

@kesane-msft Is it possible to also migrate the properties? We heavily rely on properties to know the metadata of the extension.

@kesane-msft
Copy link

@sandy081 fair ask. I have logged a bug on our side to make these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug marketplace Microsoft VS Code Marketplace issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants