Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global wordWrap setting ignored by markdown #76401

Closed
dcarapic opened this issue Jul 1, 2019 · 4 comments
Closed

Global wordWrap setting ignored by markdown #76401

dcarapic opened this issue Jul 1, 2019 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-wrapping Editor line wrapping issues

Comments

@dcarapic
Copy link

dcarapic commented Jul 1, 2019

Issue Type: Bug

The markdown files (*.md) disregard the global editor.wordWrap and editor.wordWrapColumn. If I manually add the same settings to the [markdown] file type then they are respected.

This does not work:

    "editor.wordWrap": "wordWrapColumn",
    "editor.wordWrapColumn": 180

This works:

    "[markdown]": {
        "editor.wordWrap": "wordWrapColumn",
        "editor.wordWrapColumn": 180,
        "editor.quickSuggestions": false
    },
    "editor.wordWrap": "wordWrapColumn",
    "editor.wordWrapColumn": 180

VS Code version: Code 1.35.1 (c7d83e5, 2019-06-12T14:30:02.622Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.94GB (7.27GB free)
Process Argv C:\Dload\M7 67.md
Screen Reader no
VM 0%
Extensions (16)
Extension Author (truncated) Version
xml Dot 2.5.0
gitlens eam 9.8.2
EditorConfig Edi 0.13.0
vscode-npm-script eg2 0.3.7
prettier-vscode esb 1.9.0
vscode-firefox-debug hbe 1.8.0
csharpextensions jch 1.3.0
vscode-nuget-package-manager jmr 1.1.6
docthis joe 0.7.1
docomment k-- 0.1.8
csharp ms- 1.20.0
vsliveshare ms- 1.0.471
debugger-for-chrome msj 4.11.6
indent-rainbow ode 7.4.0
code-spell-checker str 1.7.17
vscode-icons vsc 8.8.0
@vscodebot vscodebot bot added the editor-wrapping Editor line wrapping issues label Jul 1, 2019
@dcarapic
Copy link
Author

dcarapic commented Jul 1, 2019

Here is my full global settings.json (there are no local settings), I was simply editing a standalone .md file:

{
    "gitlens.advanced.messages": {
        "suppressShowKeyBindingsNotice": true
    },
    "materialTheme.fixIconsRunning": false,
    "window.zoomLevel": 1,
    "gitlens.codeLens.enabled": false,
    "gitlens.currentLine.enabled": false,
    "gitlens.hovers.currentLine.over": "line",
    "git.enableSmartCommit": true,
    "workbench.tree.indent": 18,
    "explorer.confirmDelete": false,
    "editor.codeLens": false,
    "csharp.referencesCodeLens.enabled": false,
    "gitlens.defaultDateFormat": "DD.MM.YYYY HH:mm",
    "gitlens.defaultDateShortFormat": "DD.MM.YYYY",
    "[html]": {
        "editor.defaultFormatter": "vscode.html-language-features"
    },
    "[json]": {
        "editor.defaultFormatter": "vscode.json-language-features"
    },
    "[jsonc]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "[typescriptreact]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "[typescript]": {
        "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "prettier.jsxBracketSameLine": true,
    "prettier.printWidth": 120,
    "prettier.tabWidth": 4,
    "terminal.integrated.shell.windows": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
    "editor.tabCompletion": "on",
    "editor.snippetSuggestions": "bottom",
    "workbench.iconTheme": "vscode-icons",
    "breadcrumbs.enabled": true,
    "explorer.confirmDragAndDrop": false,
    "debug.console.fontSize": 12,
    "workbench.list.horizontalScrolling": true,
    "[markdown]": {
        "editor.wordWrap": "wordWrapColumn",
        "editor.wordWrapColumn": 180,
        "editor.quickSuggestions": false
    },
    "editor.wordWrap": "wordWrapColumn",
    "editor.wordWrapColumn": 180
}

@mjbvz
Copy link
Contributor

mjbvz commented Jul 11, 2019

This feature is working as expected. Markdown provides default setting editor.wordWrap settings as a language specific setting, so you have to use "[markdown]": { ... } to override it

Adding @roblourens to see if we can improve settings UI in some way to make this more clear. (Possible duplicate of #58995 / #65844)

@roblourens
Copy link
Member

roblourens commented Jul 11, 2019

Got this to improve this as well #74195

@mjbvz
Copy link
Contributor

mjbvz commented Jul 11, 2019

Thanks. Closing as duplicate of that issue then

@mjbvz mjbvz closed this as completed Jul 11, 2019
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 11, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-wrapping Editor line wrapping issues
Projects
None yet
Development

No branches or pull requests

3 participants