New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.36 scrolling suddenly laggy - precision touchpads #76594
Comments
I have the exact same problem! |
I've started experiencing the same issue after the latest update. I have always had |
Wait, does anyone here have Is it only not smooth in the editor, or also on trees in the sidebar? |
For me, it’s everywhere: editor, sidebar, settings. |
@aloeugene what exact device and OS is that? |
@bpasero It's everywhere. I have tried toggling Device : Surface Laptop 2 - Intel Core i5-8250U |
smoothScrolling also doesn't have any noticeable difference for me, neither in 1.35.1 nor 1.36. I didn't try using a mouse when I had 1.36 installed and can currently not verify it without updating again. Can somebody currently running 1.36 confirm that the issue persists when using an external mouse to scroll and has thus nothing to do with the precision touchpad device? |
Hm, now I just updated to 1.36 again and it looks smoother than yesterday (no frame-skipping, although I didn't restart or change anything), but definitely at first glance it is much slower (smooth but very heavy to scroll, a full swipe gets me a few animated centimeters far, not a screen as i used to. The precision touchpad always scrolls smooth, the external mouse does not (only when switching on smooth scrolling), but i guess that's alright, given that the mouse wheel scrolls are measured in lines. I made videos (though they cannot capture the real 60fps+ experience one clearly sees and feels that 1.35.1 is light to scroll and 1.36 is heavy). I also used an external mouse wheel, here I don't see a difference at first glance, but then I never work with an external mouse. |
Alright, I guess I can live with that now as it is, if I adjust the 'Mouse Wheel Scroll Sensitivity' to about 3x. |
By this old page, chrome added support for precision touchpads with v68, if I read that right: |
@bpasero, I’m currently on HP EliteBook 840 G4 with Intel core i5 7th gen, 16gb RAM. Windows 10 Enterprise. Also, I’m always using touchpad, and it's the precision one, so I can’t say if this issue relates to mouse scrolling as well. |
@frevds @yo-raff @aloeugene We are building exploration builds that use a much newer version of our UI framework (Electron version 6.0.x). I wonder if this issue reproduces with one of these builds, could you try? Download: |
@bpasero, as for me on Windows, switching on/off smoothScrolling still doesn't change anything, scroll is always smooth. However, it's not that laggy anymore, quite stable and is really smooth 😃 Actually, with smoothScrolling off, it's fine and cool. But when it's on, it becomes more laggy and twitchy. |
Please do not configure the |
Well, it doesn't really change things for me. |
1.37 looks identical to me with respect to the scrolling behaviour, BUT it is very smooth (no skipping, no latency, generally usable). Just it is very animated (cannot be deactivated and scrolls out very long after letting go). Without setting the scroll sensitivity multiplicator it is too slow by default. |
@bpasero the new build has better animation when scrolling (smoother) than 1.36, but it's still worse than 1.35.1 the scrolling speed is too slow in 1.37 (new build) compared to 1.35.1 (both has same setting) |
One more thing that happened to me couple times already, but I haven't really found steps to reproduce: |
I have just done some testing with default settings and here are my findings - it mostly comes down to extensions and one specific scroll setting: |
After updating Windows to version 2004 and updating VSCode to 1.49, scrolling lags also started. On version 1.48 everything is fine. I managed to defeat them by running VSCode as administrator. If you run VSCode without administrator rights, the lags will return. Maybe this method will help someone. |
@mrtrashmind your suggestion for running as administrator worked! It's very smooth now. But it's a bit annoying to run as administrator all the time... Hope they fix this soon. Version Details: Version 1.49.1 (user setup) Dell Inspiron 7460 with Precision Touchpad |
Well, the original issue has nothing to do with extensions and also does not vanish in administrator mode. VSC is skipping frames (scrolling less smoothly than it could) and overscrolls (pushing once on the pad just scrolls on and on, pretty useless, one mustn't let go when scrolling). This behaviour is pretty much the same as scrolling in the Chrome browser. It used to be worse so one can work with it. But prior to 1.36 is used to be better. Hard to describe. One-push scroll was more rigid and the overall refresh rate was higher so everything felt much more fluent. I posted some videos up there (which due to the fps limitations don't show the true effects but give some idea). |
This is a truly awful user experience now. Reviewing/searching 20k line log files with long lines is a 3fps task. Someone please shoot a flare in the air and promote this to high priority. For an example of what good looks like please look at the speed of EmEditor. |
Running as administrator fixed this for me. |
Run as administrator did reduce the lag but not entirely solve the problem since it is still persist Edit |
Can not run as administrator on Linux. (Well could but that's bad practice). |
For users that are running as administrator to fix the issue, its unrelated to this issue. What you are seeing is #107016 and the current workaround is to launch with |
This doesn't help for me.
It's bad practice on every OS 😀 |
Issue re-appeared after my previous comment about having solved it.
I confirm this has resolved the scrolling issue for me now as well. 🥇
Thank you! |
Running as administrator on Windows helps. |
Both fixes are workarounds, so this still needs a proper solution. Both fixes may help (whatever that means) for some, but do jack all for someone else. Fact of the matter is that scrolling is lag-free in virtually every program, except VScode. And in those program, no such workaround is needed. |
People who find that flag useful might want to make it a semi-permanent fix, which I've commented here. It kinda helped me, but it's still not the experience I'd expect on high-end hardware. My laptop has both a touchscreen and a Precision Touchpad, and I've found these interesting scenarios:
I never use the touchscreen for scrolling, but do alternate a lot between touchpad and mouse. This probably has something to do with the underlying webkit engine and the way it treats inputs... I used to think it was a performance issue, and would've never noticed if I didn't have a touchscreen. |
@lesmo You might be confusing two very distinct features here:
Disabling smooth scroll is a must for me, because it get motion sickness from it. But for touch scroll (be it a touchpad or touchscreen) it has to be smooth, or I'll get motion sickness. The gist is that any gesture I physically make, has to be replicated on screen. If that doesn't happen accurately, my brain makes a mismatch that I can feel. However if you do know the difference between the two, I mean no offense by my explanation. In that case, it's a good idea to have this cleared up for anyone else who might be confused by smooth or not-smooth scrolling, and the why&when of both. |
@thany yeah, I'm pretty aware of that but to this day many touch inputs are translated to scroll wheel "clicks" in many apps. I'm guessing this provides compatibility to old software that didn't know how to handle touch input, and it might be hurting VSCode (I'm just speculating) somehow... thus I thought it would be a good idea to test it. Something like this used to happen on Mozilla Firefox, and it might be something similar. However, we obviously know that Edge and many other webkit based browsers nowadays handle touch input pretty well so, it's somewhere in there. Another speculative idea is this issue that has been closed on Electron: |
Can users confirm if this issue is present with latest stable |
After 50 versions of VS Code I honestly don't remember how it has been before. I think the scrolling experience improved slightly, it is now like in the Chrome browser on websites, when you use the Precision Touchpad, where when you scroll and let go, it keeps on scrolling for a longer while, but if you hold it while scrolling you have tight enough control over the otherwise smooth motion. This is in contrast to the 1.35 where you had direct and more rigid control with less smoothing motion (compare with the videos) - certainly a change in Chromium regarding these touchpads. |
Thanks for confirming, I was hoping for a change in runtime over the period to have improved the story here. |
Since updating to 1.36 the scrolling experience got bad.
I increased the multiplier to have the same speed, but it still feels "heavy" to scroll, not the same as before - what change could be the cause for this?
Same in the explorer view (with or without the new guides).
Here it looks like the renderer skips frames, jumpy and not calm (also the scroll multiplier does not seem to have an effect here, merely Alt).
I'm using a precision touchpad device (Dell) but this is not the old problem and cannot be solved by resizing the window.
It is especially annoying in the explorer tree, bordering close to the unusable level.
After trying for a while I will now downgrade to 1.35.x. This seamingly little handicap somehow greatly impacts productivity, at least for me, feels like having a slow computer.
Update: Yes, 1.35.1 is definitely faster and lighter to scroll (did you add some animation? my setting for 'smooth scrolling' is deactivated). I will have to stay on this version until this is fixed.
Cannot find anything in the release notes except "This is a major Electron release and comes with Chrome 69 and Node.js 10.11.0 (a major leap forward from our current version with Chrome 66 and Node.js 10.2.0)". I guess it won't be easy to locate the issue. However, the new version is not usable, for me (Windows 10, precision touchpad).
The text was updated successfully, but these errors were encountered: