Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hosting each iframe based webview in a unique origin #77132

Closed
mjbvz opened this issue Jul 10, 2019 · 2 comments
Closed

Allow hosting each iframe based webview in a unique origin #77132

mjbvz opened this issue Jul 10, 2019 · 2 comments
Assignees
@mjbvz
Labels
verification-found Issue verification failed web Issues related to running VSCode in the web
Milestone
July 2019

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jul 10, 2019

In order to better isolate webview content for iframe based webviews, we need to serve each webview from a unique origin.

This item tracks the internal work required support this use case
@mjbvz mjbvz added this to the July 2019 milestone Jul 10, 2019
@mjbvz mjbvz self-assigned this Jul 10, 2019
@mjbvz mjbvz added the web Issues related to running VSCode in the web label Jul 12, 2019
@mjbvz mjbvz closed this as completed in 5106b55 Jul 12, 2019
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Jul 12, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Jul 12, 2019

This change needs a small code/config change to actually test. Just apply the latest change from https://github.com/microsoft/vscode/tree/dev/mjbvz/77132 to master to test on web

@mjbvz
Copy link
Contributor Author

mjbvz commented Jul 22, 2019 •
edited

Actually easier to test now, just set: "webview.experimental.useExternalEndpoint": true

To verify, use the web inspector to verify that iframe based webviews are being used and are loading from a unique endpoint each time

@lramos15 lramos15 added the verification-found Issue verification failed label Jul 30, 2019
This was referenced Jul 30, 2019
Closed
Closed
@lramos15 lramos15 removed the verification-needed Verification of issue is requested label Jul 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
verification-found Issue verification failed web Issues related to running VSCode in the web
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
2 participants
@lramos15 @mjbvz