Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DisposableStore in terminal #77148

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Use DisposableStore in terminal #77148

merged 1 commit into from
Jul 11, 2019

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Jul 10, 2019

Switches some places in the terminal code to use a DisposableStore instead of an array of IDisposables

@mjbvz
Use DisposableStore in terminal
706bf64 
Switches some places in the terminal code to use a DisposableStore instead of an array of IDisposables
@mjbvz mjbvz added this to the July 2019 milestone Jul 10, 2019
@mjbvz mjbvz requested a review from Tyriar July 10, 2019 22:07
@mjbvz mjbvz self-assigned this Jul 10, 2019
Tyriar
Tyriar approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar Tyriar requested a review from alexr00 July 10, 2019 23:26
alexr00
alexr00 reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terminalTaskSystem.ts ✔

@Tyriar Tyriar merged commit b2ac640 into microsoft:master Jul 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjbvz @Tyriar @alexr00