Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High contrast theme has a UX issue with the cursor. #77368

Closed
envygeeks opened this issue Jul 14, 2019 · 7 comments
Closed

High contrast theme has a UX issue with the cursor. #77368

envygeeks opened this issue Jul 14, 2019 · 7 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug ux User experience issues verified Verification succeeded
Milestone

Comments

@envygeeks
Copy link

  • VSCode Version: 1.35.1
  • OS Version: macOS latest

Steps to Reproduce:

  1. Use the high contrast theme
  2. Wish yourself luck trying to figure out where the cursor actually is
  3. Cry a little

When using the high-contrast theme, one cannot easily determine where the cursor actually is because the box around certain stuff obscures it, and a bolded left, or right side hardly points to where the cursor actually is because the old portions weight is not enough to easily determine in a sub-second like outside of high contrast themes (actually if we were highly technical the same applies to non-high contrast as well because the cursor is often too thin)

image

@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues labels Jul 17, 2019
@rebornix
Copy link
Member

Can editor.cursorStyle and editor.cursorWidth help mitigate the issue?

@rebornix rebornix added the info-needed Issue requires more information from poster label Jul 17, 2019
@envygeeks
Copy link
Author

Phased cursors throw off my view and distract me, width might help, but if I'm honest, having it the same color as the orange line above and below to indicate the split where the cursor is would provide the best indication.

@rebornix
Copy link
Member

@envygeeks 👍

@misolori I'll leave it to you to choose a good color ;)

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jul 18, 2019

Here's what it would look like being the same color as our focus color:

image

However, this makes it a bit harder to see in other instances:

image

You can try this out via:

"workbench.colorCustomizations": {
        "editorCursor.foreground": "#F38518"
    }

@miguelsolorio
Copy link
Contributor

What if we updated editorBracketMatch.border to a different color? That at least have better contrast than white on white:

image

@envygeeks
Copy link
Author

@misolori indeed I was able to spot the cursor almost instantly in your second example I'm 👍 on that

@miguelsolorio
Copy link
Contributor

This is now fixed and will be in the next release:

image

@miguelsolorio miguelsolorio added this to the July 2019 milestone Jul 18, 2019
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster under-discussion Issue is under discussion for relevance, priority, approach labels Jul 18, 2019
@miguelsolorio miguelsolorio added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jul 18, 2019
@lramos15 lramos15 added the verified Verification succeeded label Jul 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug ux User experience issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants