Terminal picker is off

[chrisdias]

Issue Type: Bug

VS Code version: Code - Insiders 1.37.0-insider (8fa8111, 2019-07-12T09:17:10.495Z)
OS version: Darwin x64 17.7.0
Remote OS version: Linux x64 4.18.0-1024-azure

I'm connected remotely to a VM in Azure over SSH. I noticed that my terminal picker looked like this:

And when i clicked on it, the separator was checked!

Once I clicked on a terminal (e.g. I clicked on bash) the problem went away.

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	3, 3, 3
Memory (System)	16.00GB (1.74GB free)
Process Argv	-psn_0_12962908
Screen Reader	no
VM	0%

Item	Value
Remote	SSH: cdias-devbox
OS	Linux x64 4.18.0-1024-azure
CPUs	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz (2 x 2394)
Memory (System)	7.77GB (6.24GB free)
VM	0%

Extensions (19)

Extension	Author (truncated)	Version
vsc-material-theme	Equ	29.2.0
vscode-peacock	joh	2.4.0
dotenv	mik	1.0.1
vscode-docker	ms-	0.7.0
remote-containers	ms-	0.66.0
remote-ssh-edit-nightly	ms-	2019.7.21060
remote-ssh-explorer-nightly	ms-	2019.7.21060
remote-ssh-nightly	ms-	2019.7.21060
remote-wsl	ms-	0.38.10
vscode-remote-extensionpack	ms-	0.15.0
cloudenv	ms-	1.0.488
cloudenv-explorer	ms-	1.0.488
cloudenv-extensions	ms-	1.0.488
debugger-for-chrome	msj	4.11.6
vscode-openapi	42C	1.8.3
vscode-azurefunctions	ms-	0.17.1
vscode-kubernetes-tools	ms-	1.0.1
azure-account	ms-	0.8.4
vscode-yaml	red	0.4.1

(2 theme extensions excluded)

[chrisdias]

looks like it happens on first connect...

[Tyriar]

I repro'd this by turning on show login terminal and connecting to an ssh box.

[Tyriar]

This appears to happen because of the short-lived "install" terminal

[Tyriar]

This is merged, I'll manually verify it in tomorrow's build though.

[Tyriar]

This wasn't actually fixed

[Tyriar]

Another repro in #78405

[Tyriar]

I think this is fixed