Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use map instead of object literals in mainThreadTerminalService #77421

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Use map instead of object literals in mainThreadTerminalService #77421

merged 1 commit into from
Jul 15, 2019

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Jul 15, 2019

Replaces a few uses of object literals with regular maps, which better enforce type correctness

@mjbvz
Use map instead of object literals in mainThreadTerminalService
618da58 
Replaces a few uses of object literals with regular maps, which  better enforce type correctness
@mjbvz mjbvz requested a review from Tyriar July 15, 2019 19:01
@mjbvz mjbvz self-assigned this Jul 15, 2019
@Tyriar Tyriar added this to the July 2019 milestone Jul 15, 2019
@Tyriar Tyriar merged commit 23b9621 into microsoft:master Jul 15, 2019
@Tyriar
Copy link
Member

Tyriar commented Jul 15, 2019

Thanks 😃

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
July 2019
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjbvz @Tyriar