Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Protocol command 'Target.getBrowserContexts' #77491

Closed
caslt opened this issue Jul 17, 2019 · 1 comment
Closed

Implementing Protocol command 'Target.getBrowserContexts' #77491

caslt opened this issue Jul 17, 2019 · 1 comment
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@caslt
Copy link

caslt commented Jul 17, 2019

I met an issue when using puppeteer to connect to an existing VSCode instance.
I use these steps

  1. Open a instance by code . --remote-debugging-port=9222
  2. Get the WSEndPoint in http://localhost:9222/json/version
  3. Connect to this VSCode instance by puppeteer.connect, with the WSEndPoint get from step 2

However, puppeteer throw an error saying command 'Target.getBrowserContexts' is not supported.

I could see it sends command and waiting for a correct response, in Launcher.js
const {browserContextIds} = await connection.send('Target.getBrowserContexts');

So I tried to fix this by puppeteer/puppeteer#4720

However, as the other page mentioned puppeteer/puppeteer#4283, the command should be implemented by electron apps.

So could you please support the protocol command 'Target.getBrowserContexts'

@weinand
Copy link
Contributor

weinand commented Jul 17, 2019

Please file this issue against electron.

@weinand weinand closed this as completed Jul 17, 2019
@weinand weinand added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 17, 2019
@weinand weinand removed their assignment Jul 17, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants