Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignService: No need to cache the import #78186

Closed
isidorn opened this issue Jul 30, 2019 · 0 comments
Closed

SignService: No need to cache the import #78186

isidorn opened this issue Jul 30, 2019 · 0 comments
Assignees
@isidorn
Labels
debt Code quality issues
Milestone
August 2019

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 30, 2019

Code pointer
https://github.com/Microsoft/vscode/blob/18f4630bc51a3d87c7b31d96ca9c8ea95aa649b0/src/vs/platform/sign/node/signService.ts#L14

Since underlying issue is fixed #75257 (comment)
@isidorn isidorn added the debt Code quality issues label Jul 30, 2019
@isidorn isidorn added this to the August 2019 milestone Jul 30, 2019
@isidorn isidorn self-assigned this Jul 30, 2019
@isidorn isidorn mentioned this issue Jul 30, 2019
Closed
@isidorn isidorn closed this as completed in 6b07085 Aug 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
1 participant
@isidorn