Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German localization misses Extensions viewlet title #78383

Closed
joaomoreno opened this issue Aug 2, 2019 · 4 comments
Closed

German localization misses Extensions viewlet title #78383

joaomoreno opened this issue Aug 2, 2019 · 4 comments
Assignees
Milestone

Comments

@joaomoreno
Copy link
Member

The Extensions viewlet title should be Erweiterungen and it seems that it has changed to Extensions. Not sure if this was a purposeful decision from the localization team.

Commented out the smoke test assertion for now: 709a07d

@dbaeumer
Copy link
Member

dbaeumer commented Aug 6, 2019

I think it is more likely that code got shuffled around and this needs a new LP from the translation team which should come with when we release 1.37. Let's see if this fixes it.

@dbaeumer
Copy link
Member

dbaeumer commented Aug 6, 2019

Actually, there is no a mix of Extensions and Erweiterung in the UI even embedded in German sentences. So it doesn't look like a LP issue.

capture

@danyeh can you please make sure this gets consistent, either using Erweiterungen or Extensions. But the current form is unhappy.

@dbaeumer dbaeumer added this to the August 2019 milestone Aug 6, 2019
@lukaschal
Copy link

Strings localized correctly in a MLCP and json file.

https://github.com/madcoder2k17/visualstudio-code/blob/master/i18n/deu/src/vs/workbench/parts/extensions/browser/extensionsActions.i18n.json

"showOutdatedExtensions": "Veraltete Erweiterungen anzeigen",
"showPopularExtensions": "Beliebte Erweiterungen anzeigen",
"showRecommendedExtensions": "Empfohlene Erweiterungen anzeigen",
"showWorkspaceRecommendedExtensions": "Für den Arbeitsbereich empfohlene Erweiterungen anzeigen",
"showRecommendedKeymapExtensions": "Empfohlene Tastenzuordnungen anzeigen",

@dbaeumer dbaeumer removed their assignment Aug 27, 2019
@barnabasn
Copy link

The strings are fixed in the freshly published language pack (1.38.1):
image
Please close this issue if you are satisfied with the fix.

@alexdima alexdima modified the milestones: August 2019, On Deck Aug 29, 2019
@danyeh danyeh closed this as completed Jun 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants