Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize extension terminals (vscode.Pseudoterminal) #78514

Closed
Tyriar opened this issue Aug 5, 2019 · 1 comment
Closed

Stabilize extension terminals (vscode.Pseudoterminal) #78514

Tyriar opened this issue Aug 5, 2019 · 1 comment
Assignees
Labels
api api-finalization feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 5, 2019

No description provided.

@Tyriar Tyriar added feature-request Request for new features or functionality api terminal Integrated terminal issues api-finalization labels Aug 5, 2019
@Tyriar Tyriar self-assigned this Aug 5, 2019
@Tyriar Tyriar added this to the September 2019 milestone Aug 5, 2019
@Tyriar Tyriar closed this as completed in afe9120 Sep 4, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Sep 30, 2019

This was tested in depth last iteration so to verify just make sure that the API is present as a non-proposed API and doesn't require enableProposedApi in the package.json to use.

Simple example:

const writeEmitter = new vscode.EventEmitter<string>();
const pty: vscode.Pseudoterminal = {
  onDidWrite: writeEmitter.event,
  open: () => writeEmitter.fire('\x1b[31mHello world\x1b[0m'),
  close: () => {}
};
vscode.window.createTerminal({ name: 'My terminal', pty });

@Tyriar Tyriar added the verification-needed Verification of issue is requested label Sep 30, 2019
@jrieken jrieken added the verified Verification succeeded label Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants