web - enable sourcemaps #78690
Merged
web - enable sourcemaps #78690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
reviewed
Aug 8, 2019
| // optionally allow to pass in explicit base/maps to upload | ||
| const args = process.argv.slice(2); | ||
| const base = args[0]; | ||
| const maps = args[1]; |
There was a problem hiding this comment.
Where are your ES3000 skillz? 🥇
const [base, maps, ...args] = process.argv;There was a problem hiding this comment.
@joaomoreno I guess in the same place where your node.js skillz are.
Went with this:
const [base, maps] = process.argv.slice(2);There was a problem hiding this comment.
Ahah yeah const [,,base, maps] = process.argv;
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @joaomoreno