Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
additionalScrollHeight
option to thelist
and propagets it through thetree
classes. This option allows the list clients to specify additionalscrollHeight
. I decided to make this anumber
, not aboolean
since clients are in charge of the height of each element.Here the explorer also starts using this options, specifying twice the element height.
The motivation for this is to tackle #1043 so it would be easier for users to create top level elements in the full explorer by scrolling all the way down.
I tried it out and I actually like how it feels.
Let me know what you think and thanks for the review.