New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish breadcrumbs icons spacing #79160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test that this doesn't have an affect to other places where these icons are being used? symbol-icon
is popular, being used for quick outline and the outline tree as well.
I've found ✅ Well I'll find a better way to add some spacing |
It would be great if you upload a screenshot of both previous and after your change. |
@jrieken thank you for review. I've created a special css rule to fix that issue. I'm not sure that |
Did you test your change and see the effect when you build your instance of vscode? |
Changes look better (less risky). Thanks. Maybe move the change above line 20 as the rules in that range talk about |
wrt the value, I feel like the padding should be 4px. It's a little hard to compare as the tree shows items in a larger font (and uses a different implementation) |
@MJ-Mohith yes, I did @jrieken Sure, today I'll move this rule above. And about the padding: I've seen the tree's padding is 4px, however So I've selected 6px as value because it's a breadcrumb item too. Well should I change it to 4px? |
Ah, that's where it comes from. Yeah, makes sense then. Consistency is key |
Thanks |
Hey,
There is a simple fix for #79005