Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive window controls on Mac are hard to see on light themes #80007

Closed
miguelsolorio opened this issue Aug 28, 2019 · 3 comments
Closed

Inactive window controls on Mac are hard to see on light themes #80007

miguelsolorio opened this issue Aug 28, 2019 · 3 comments
Assignees
Labels
info-needed Issue requires more information from poster macos Issues with VS Code on MAC/OS X

Comments

@miguelsolorio
Copy link
Contributor

This seems like a bug where something changed, dark themes are fine but the light themes makes the controls hard to see:

Dark

image

Light

image

Others

image

image

@miguelsolorio miguelsolorio added the macos Issues with VS Code on MAC/OS X label Aug 28, 2019
@bpasero
Copy link
Member

bpasero commented Aug 29, 2019

@misolori looks OK to me:

image

Did you configure a color for the inactive title?

Does it reproduce in stable with same settings?

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 29, 2019
@vscodebot vscodebot bot closed this as completed Sep 5, 2019
@vscodebot
Copy link

vscodebot bot commented Sep 5, 2019

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@miguelsolorio
Copy link
Contributor Author

This repros on stable and I think this is happening when you are on dark mode in the OS and your VS Code theme is set to light. See here as I toggle the OS theme (notice how Finder updates):

gif

It appears that this expected behavior but it's a problem because we don't update the title bar based on the OS title bar. Up to you if you want to re-open.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster macos Issues with VS Code on MAC/OS X
Projects
None yet
Development

No branches or pull requests

2 participants