Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal open separate from main app window, (cmd, powershell, bash) #80180

Closed
tsukasa696 opened this issue Sep 1, 2019 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster

Comments

@tsukasa696
Copy link

terminal_vscode

  • VSCode Version:
    Version: 1.37.1 (system setup)
    Commit: f06011a
    Date: 2019-08-15T16:17:55.855Z
    Electron: 4.2.7
    Chrome: 69.0.3497.128
    Node.js: 10.11.0
    V8: 6.9.427.31-electron.0
    OS: Windows_NT x64 10.0.18362

  • OS Version: Windows 10 Pro, version 1903, build 18362.295

Steps to Reproduce:

  1. Open integrated terminal

Does this issue occur when all extensions are disabled?: Yes

This start to happen today, the last time i use was on Friday Vs Code was working perfectly, i start the vs code with all the ext disabled and was the same, i will appreciate any help

@weinand
Copy link
Contributor

weinand commented Sep 1, 2019

@tsukasa696 did you change the terminal.explorerKind setting to external? Try setting it to integrated.

@weinand weinand added the info-needed Issue requires more information from poster label Sep 1, 2019
@tsukasa696
Copy link
Author

Hi @weinand ! My settings.json has being the same as when i install and mod to use different cmd

"shellLauncher.shells.windows": [{
            "shell": "C:\\Windows\\System32\\cmd.exe",
            "label": "cmd"
        },
        {
            "shell": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
            "label": "PowerShell"
        },
        {
            "shell": "D:\\Program Files\\Git\\bin\\bash.exe",
            "label": "Git bash"
        },
        {
            "shell": "D:\\Program Files\\cmder\\cmder.exe",
            "Label": "Cmder"
        }
    ],
"terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\cmd.exe",

the last update i did to that file was on September/October last year no new changes, and was working really fine

@weinand
Copy link
Contributor

weinand commented Sep 2, 2019

All those settings you mentioned above are irrelevant to the problem you are seeing. Please change "terminal.explorerKind" and see whether that makes a difference.

@cnscorpions
Copy link

same issue with tsukasa696, but not work for me to change "terminal.explorerKind" setting

Launch VS Code
Type Ctrl + `
Expected: View Terminal
Actual: Open Windows powershell, not integrated terminal

version: 1.37.1 (system setup)
OS: Windows_NT x64 10.0.18362

@tsukasa696
Copy link
Author

All those settings you mentioned above are irrelevant to the problem you are seeing. Please change "terminal.explorerKind" and see whether that makes a difference.

i try your recommendation and still the same issue, i clean the settings.json and was the same result so i rollback

@Tyriar
Copy link
Member

Tyriar commented Sep 6, 2019

/duplicate #73790, you need to disable legacy console mode in cmd.exe/conhost's properties.

@Tyriar Tyriar closed this as completed Sep 6, 2019
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants