Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Webview gets restored only when setState is executed #80184

Closed
akaroml opened this issue Sep 2, 2019 · 3 comments
Closed

Regression - Webview gets restored only when setState is executed #80184

akaroml opened this issue Sep 2, 2019 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues

Comments

@akaroml
Copy link
Member

akaroml commented Sep 2, 2019

This was originally tracked by #50752 and was supposed to be fixed by 6e81adc

But this is still happening. I have to work around it by calling setState({}) to get the view restored. Here's the VS Code version I'm using.

Version: 1.37.1
Commit: f06011a
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

@vscodebot
Copy link

vscodebot bot commented Sep 2, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@mjbvz
Copy link
Contributor

mjbvz commented Sep 3, 2019

Does this reproduce in the latest VS Code insiders build?

@akaroml
Copy link
Member Author

akaroml commented Sep 4, 2019

Yes it's still reproducible in the insider build:

Version: 1.38.0-insider
Commit: 5ab84ce
Date: 2019-09-02T07:48:28.922Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0
out

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues labels Sep 10, 2019
@mjbvz mjbvz added this to the September 2019 milestone Sep 10, 2019
@mjbvz mjbvz closed this as completed in e62f2e3 Sep 23, 2019
@roblourens roblourens added the verified Verification succeeded label Oct 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants